fixing messages not being rendered inside threads#1033
Merged
Spiral-Memory merged 2 commits intoRocketChat:developfrom Dec 10, 2025
Merged
fixing messages not being rendered inside threads#1033Spiral-Memory merged 2 commits intoRocketChat:developfrom
Spiral-Memory merged 2 commits intoRocketChat:developfrom
Conversation
Collaborator
|
Thanks for consistently fixing bugs as Rocket.Chat new API evolves. Everything was working before, but it seems the recent changes in the API might be causing these issues. It might be a good idea to create a main issue to update it in line with Rocket.Chat’s APIs and include Rocket.Chat DDP, as shown in this PR: #1009 |
Spiral-Memory
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
Fixing the unnecessary query parameters for the getThreadMessages endpoint which is used to fetch the messages of respective threads.
Fixes #1032
Video/Screenshots
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1033 after approval. Contributors are requested to replace <pr_number> with the actual PR number.